Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9332] Added optional topologySpreadConstraints configuration #155

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lidiams96
Copy link

Description

This pull request introduces optional configuration for topologySpreadConstraints in the Helm chart for better control over pod distribution across nodes.

Changes Made

  • values.yaml: Added topologySpreadConstraints: [] to each component block, allowing users to define topology spread constraints if needed.
  • templates/component.yaml: Included logic to render topologySpreadConstraints from values.yaml if specified.

Benefits

These changes provide the flexibility to specify pod distribution constraints, improving resilience and availability by ensuring pods are evenly spread across failure domains.

Backwards Compatibility

The default configuration keeps topologySpreadConstraints empty, ensuring no impact on existing deployments that do not require this feature.

@lidiams96 lidiams96 requested a review from a team as a code owner June 27, 2024 16:15
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-9332

@bitwarden-bot bitwarden-bot changed the title Added optional topologySpreadConstraints configuration [PM-9332] Added optional topologySpreadConstraints configuration Jun 27, 2024
@bitwarden-bot bitwarden-bot added in-product-review Community PR is being reviewed by Bitwarden's Product team community-pr labels Jun 27, 2024
@bitwarden-bot
Copy link

bitwarden-bot commented Jun 27, 2024

Logo
Checkmarx One – Scan Summary & Details47b51263-7425-44e8-bc45-7f99b9e1c8ff

No New Or Fixed Issues Found

@djsmith85 djsmith85 requested a review from a team July 17, 2024 13:43
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-pr in-product-review Community PR is being reviewed by Bitwarden's Product team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants