PM-17795: Allow carousel, create account, and import logins feature f…

…lags to be configured remotely
bitwarden · Jan 31, 2025 · 9395ce3 · 9395ce3
1 parent c41b77d
commit 9395ce3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/BitwardenShared/Core/Platform/Models/Enum/FeatureFlag.swift b/BitwardenShared/Core/Platform/Models/Enum/FeatureFlag.swift
@@ -113,9 +113,6 @@ enum FeatureFlag: String, CaseIterable, Codable {
         case .enableCipherKeyEncryption,
              .enableDebugAppReviewPrompt,
              .ignore2FANoticeEnvironmentCheck,
-             .importLoginsFlow,
-             .nativeCarouselFlow,
-             .nativeCreateAccountFlow,
              .newDeviceVerificationPermanentDismiss,
              .newDeviceVerificationTemporaryDismiss,
              .testLocalFeatureFlag,
@@ -129,6 +126,9 @@ enum FeatureFlag: String, CaseIterable, Codable {
              .cxpImportMobile,
              .emailVerification,
              .enableAuthenticatorSync,
+             .importLoginsFlow,
+             .nativeCarouselFlow,
+             .nativeCreateAccountFlow,
              .refactorSsoDetailsEndpoint,
              .sshKeyVaultItem,
              .testRemoteFeatureFlag,

diff --git a/BitwardenShared/Core/Platform/Models/Enum/FeatureFlagTests.swift b/BitwardenShared/Core/Platform/Models/Enum/FeatureFlagTests.swift
@@ -25,6 +25,9 @@ final class FeatureFlagTests: BitwardenTestCase {
         XCTAssertTrue(FeatureFlag.cxpImportMobile.isRemotelyConfigured)
         XCTAssertTrue(FeatureFlag.emailVerification.isRemotelyConfigured)
         XCTAssertTrue(FeatureFlag.enableAuthenticatorSync.isRemotelyConfigured)
+        XCTAssertTrue(FeatureFlag.importLoginsFlow.isRemotelyConfigured)
+        XCTAssertTrue(FeatureFlag.nativeCarouselFlow.isRemotelyConfigured)
+        XCTAssertTrue(FeatureFlag.nativeCreateAccountFlow.isRemotelyConfigured)
         XCTAssertTrue(FeatureFlag.refactorSsoDetailsEndpoint.isRemotelyConfigured)
         XCTAssertTrue(FeatureFlag.sshKeyVaultItem.isRemotelyConfigured)
         XCTAssertTrue(FeatureFlag.testRemoteInitialBoolFlag.isRemotelyConfigured)
@@ -34,9 +37,6 @@ final class FeatureFlagTests: BitwardenTestCase {
         XCTAssertFalse(FeatureFlag.enableDebugAppReviewPrompt.isRemotelyConfigured)
         XCTAssertFalse(FeatureFlag.enableCipherKeyEncryption.isRemotelyConfigured)
         XCTAssertFalse(FeatureFlag.ignore2FANoticeEnvironmentCheck.isRemotelyConfigured)
-        XCTAssertFalse(FeatureFlag.importLoginsFlow.isRemotelyConfigured)
-        XCTAssertFalse(FeatureFlag.nativeCarouselFlow.isRemotelyConfigured)
-        XCTAssertFalse(FeatureFlag.nativeCreateAccountFlow.isRemotelyConfigured)
         XCTAssertFalse(FeatureFlag.testLocalFeatureFlag.isRemotelyConfigured)
         XCTAssertFalse(FeatureFlag.testLocalInitialBoolFlag.isRemotelyConfigured)
         XCTAssertFalse(FeatureFlag.testLocalInitialIntFlag.isRemotelyConfigured)