Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-17008: Send updates #1305

Merged
merged 5 commits into from
Jan 28, 2025
Merged

PM-17008: Send updates #1305

merged 5 commits into from
Jan 28, 2025

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Jan 28, 2025

🎟️ Tracking

PM-17008 - Update notes label to "Private note"
PM-17009 - Change "New Password" subtext
PM-17010 - Remove "Deactivate this send" toggle from Text/File Sends

📔 Objective

Updates to the add/edit sends screen:

  • Notes field renamed to "Private note" and remove footer text.
  • Update the footer text for setting a password.
  • Remove "Deactivate this send" toggle.
  • Move notes below hide email toggle.

📸 Screenshots

Before After
Screenshot 2025-01-27 at 9 56 59 PM Screenshot 2025-01-27 at 9 55 18 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details361e3a3a-2c94-41d4-aca0-ffc2a80b3243

Great job, no security vulnerabilities found in this Pull Request

Copy link
Contributor

@KatherineInCode KatherineInCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming our conclusions about Crowdin and how changed strings are handled is correct, this all looks quite straightforward.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (497a0f9) to head (bd6efb6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
- Coverage   89.47%   89.45%   -0.03%     
==========================================
  Files         740      743       +3     
  Lines       46431    46583     +152     
==========================================
+ Hits        41544    41669     +125     
- Misses       4887     4914      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-livefront matt-livefront merged commit 9981c9b into main Jan 28, 2025
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-17008-send-updates branch January 28, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants