-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8222] Identity new device verification #1312
Conversation
…e and processor error handling.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 89.43% 89.43%
=======================================
Files 745 745
Lines 46624 46636 +12
=======================================
+ Hits 41697 41708 +11
- Misses 4927 4928 +1 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few picks.
BitwardenShared/UI/Auth/Login/LoginWithDevice/LoginWithDeviceProcessor.swift
Show resolved
Hide resolved
BitwardenShared/Core/Auth/Models/Response/IdentityTokenErrorModel.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Federico Maccaroni <[email protected]>
🎟️ Tracking
PM-8222
📔 Objective
Identity will now send error 400 when a user tries to get a token with a new device.
To verify the device, the user will have to send an otp code.
This PR updates the network layer request models to handle this error.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes