Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8222] Identity new device verification #1312

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

andrebispo5
Copy link
Contributor

@andrebispo5 andrebispo5 commented Jan 29, 2025

🎟️ Tracking

PM-8222

📔 Objective

Identity will now send error 400 when a user tries to get a token with a new device.
To verify the device, the user will have to send an otp code.
This PR updates the network layer request models to handle this error.

{
    "error": "device_error",
    "error_description": "New device verification required",
    "ErrorModel": {
        "Message": "new device verification required",
        "Object": "error"
    }
}

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.43%. Comparing base (9f6b685) to head (7184564).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
BitwardenShared/UI/Auth/Login/LoginProcessor.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files         745      745           
  Lines       46624    46636   +12     
=======================================
+ Hits        41697    41708   +11     
- Misses       4927     4928    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Logo
Checkmarx One – Scan Summary & Details1bbfd330-410e-4745-8301-c257e97a145b

Great job, no security vulnerabilities found in this Pull Request

Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few picks.

@andrebispo5 andrebispo5 requested a review from fedemkr January 30, 2025 22:01
@andrebispo5 andrebispo5 merged commit c41b77d into main Jan 31, 2025
9 checks passed
@andrebispo5 andrebispo5 deleted the pm-8222/update-identity-request branch January 31, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants