[PM-17710] Fix NotificationCenterServiceTests race condition failure

[fedemkr]

🎟️ Tracking

PM-17710

📔 Objective

Fix NotificationCenterServiceTests race condition failure that caused tests to execute until timeout or fail randomly with the new maximum-test-execution-time-allowance setting.

This was caused when notificationCenter.post(...) was executed before the iterator.next() started. Therefore the notification value was missed from the publisher and the test never ended.

In order to fix this without adding an explicit Task.sleep(...) I've moved the for await in publisher to the setup where a flag is set when the value is received and then I call the notificationCenter.post(...) inside the try await waitForAsync { ... } so if the first time the post is missed then it will loop again in it waitForAsync and post again until the publisher is ready, receives the notification value and updates the flag.

I've run each test 100 times locally and with the fix all passed whereas before in around 30-40 times runs it was failing.
Plus all runs of each test are under 0,5 seconds so we're inside the maximum-test-execution-time-allowance of 1 second.
So hopefully we won't encounter these tests failing in CI anymore.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – da7d3208-2b52-46e8-beb4-59a03efe1586

Great job, no security vulnerabilities found in this Pull Request

[KatherineInCode]

👍🏻 Good catch, and I like this solution!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (c746146) to head (ad29f30).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
- Coverage   89.44%   89.43%   -0.01%     
==========================================
  Files         743      745       +2     
  Lines       46590    46621      +31     
==========================================
+ Hits        41671    41695      +24     
- Misses       4919     4926       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.