Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9534] Update SDK revision to 71dc81c #706

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jul 5, 2024

🎟️ Tracking

PM-9534

📔 Objective

Update SDK revision to 71dc81cb29ad2d3634a99c6a3d0823624ee1b152:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr marked this pull request as ready for review July 5, 2024 15:26
@fedemkr fedemkr requested review from matt-livefront and a team July 5, 2024 15:26
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (5fd083d) to head (7514786).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files         562      562           
  Lines       27973    27973           
=======================================
  Hits        24566    24566           
  Misses       3407     3407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 5, 2024

Logo
Checkmarx One – Scan Summary & Detailsa14924e8-ab1b-4ed1-9416-36a1fce6f7c9

No New Or Fixed Issues Found

@fedemkr fedemkr merged commit cd50cd7 into main Jul 8, 2024
8 checks passed
@fedemkr fedemkr deleted the mobiletf/pm-9534/update-sdk-71dc81c branch July 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants