Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stepup client method #33

Merged
merged 13 commits into from
Jun 11, 2024
Merged

Added stepup client method #33

merged 13 commits into from
Jun 11, 2024

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Apr 23, 2024

Ticket

Description

This adds the stepup client method for authenticating a user for a specific purpose or action.

Shape

Stepup is an overload for the signin method with the addition of the purpose to signinBegin.

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • Tested the generated js file in the Passwordless dotnet sdk repo and used that instead of the cdn.

I did the following to ensure that my changes do not introduce security vulnerabilities:
N/A

@jrmccannon jrmccannon requested a review from a team as a code owner April 23, 2024 15:06
Copy link
Member

@jonashendrickx jonashendrickx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do the formatting separately

@jrmccannon
Copy link
Contributor Author

jrmccannon commented May 30, 2024

Formatting changes can be found in this PR

#41

Tyrrrz
Tyrrrz previously approved these changes May 30, 2024
@jrmccannon
Copy link
Contributor Author

Maybe do the formatting separately

Formatting changes have been applied @jonashendrickx

@jrmccannon jrmccannon requested a review from Tyrrrz May 31, 2024 14:00
jonashendrickx
jonashendrickx previously approved these changes Jun 4, 2024
jonashendrickx
jonashendrickx previously approved these changes Jun 10, 2024
src/passwordless.ts Outdated Show resolved Hide resolved
src/passwordless.ts Outdated Show resolved Hide resolved
@jrmccannon jrmccannon requested a review from Tyrrrz June 10, 2024 15:28
@Tyrrrz
Copy link
Contributor

Tyrrrz commented Jun 11, 2024

Let's merge this before #45 to reduce merge conflicts

@jrmccannon jrmccannon merged commit f8f81c9 into main Jun 11, 2024
2 checks passed
@jrmccannon jrmccannon deleted the PAS299-step-up branch June 11, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants