Generate passwordless.d.ts types #88
Merged
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
This outputs a single
passwordless.d.ts
file, including typings from both types.ts and passwordless.ts.I do think this approach has a problem in that the types from types.ts are not marked withFixed in later commit. (see comparison with 1.2.0-beta1 build output below)export
in the generated assetTo compare with the output from 1.2.0-beta (before rollup was upgraded), the output was: