[PM-11789] Build sdk-client #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
- Coverage 58.24% 58.16% -0.09%
==========================================
Files 197 197
Lines 13504 13523 +19
==========================================
Hits 7865 7865
- Misses 5639 5658 +19 ☔ View full report in Codecov by Sentry. |
vgrassia
previously approved these changes
Sep 10, 2024
coltonhurst
requested changes
Sep 11, 2024
coltonhurst
approved these changes
Sep 13, 2024
coltonhurst
requested changes
Sep 13, 2024
Comment on lines
+30
to
36
| async loginAccessToken(accessToken: string): Promise<void> { | ||
| const response = await this.client.run_command( | ||
| Convert.commandToJson({ | ||
| accessTokenLogin: { | ||
| loginAccessToken: { | ||
| accessToken, | ||
| }, | ||
| }), |
There was a problem hiding this comment.
Ah, one other note. Changing this will break the example file example/index.js. We probably want to update the example with that fix and we should probably include an example using the password function as well.
coltonhurst
approved these changes
Sep 19, 2024
Hinton
commented
Oct 1, 2024
There was a problem hiding this comment.
We should completely remove the fallback since PM won't use these bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11789
📔 Objective
Publish sdk-client to gh packages npm.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes