Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1444] Fix Windows GNU Builds #1053

Merged
merged 8 commits into from
Sep 19, 2024
Merged

[SM-1444] Fix Windows GNU Builds #1053

merged 8 commits into from
Sep 19, 2024

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Sep 17, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1444

📔 Objective

Windows GNU builds are currently broken due to a bug in rustls-platform-verifier when LTO is turned on.

I have submitted a GH Issue for this here: rustls/rustls-platform-verifier#141

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst self-assigned this Sep 17, 2024
@coltonhurst coltonhurst changed the title SM-1444: Fix Windows GNU Builds [SM-1444] Fix Windows GNU Builds Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Logo
Checkmarx One – Scan Summary & Details7a698926-8f7d-47a0-8315-6da8cb0a4cf6

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 341 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 338
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 131
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 86
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 173
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 192
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 66
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 198
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 58
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 54
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 61
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 124

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.16%. Comparing base (1309527) to head (1c5e1f4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   58.24%   58.16%   -0.09%     
==========================================
  Files         197      197              
  Lines       13504    13523      +19     
==========================================
  Hits         7865     7865              
- Misses       5639     5658      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coltonhurst coltonhurst marked this pull request as ready for review September 17, 2024 20:12
@coltonhurst coltonhurst requested a review from a team as a code owner September 17, 2024 20:12
Copy link
Contributor

@michalchecinski michalchecinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added two renaming suggestions to reflect better which systems they should run for. This will result in better visibility of whether the appropriate build step has been run.

@coltonhurst
Copy link
Member Author

@michalchecinski I think it might be beneficial to leave the explicit targets as is?

For musl, it could be two different targets, x86_64-unknown-linux-musl or aarch64-unknown-linux-musl. If we just make it Build rust for musl it won't be immediately obvious which architecture it is.

@coltonhurst coltonhurst merged commit 7641717 into main Sep 19, 2024
78 of 80 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1444 branch September 19, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants