-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1444] Fix Windows GNU Builds #1053
Conversation
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
- Coverage 58.24% 58.16% -0.09%
==========================================
Files 197 197
Lines 13504 13523 +19
==========================================
Hits 7865 7865
- Misses 5639 5658 +19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added two renaming suggestions to reflect better which systems they should run for. This will result in better visibility of whether the appropriate build step has been run.
@michalchecinski I think it might be beneficial to leave the explicit targets as is? For |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1444
📔 Objective
Windows GNU builds are currently broken due to a bug in rustls-platform-verifier when LTO is turned on.
I have submitted a GH Issue for this here: rustls/rustls-platform-verifier#141
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes