Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1445] Fix Go build on Windows #1059

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[SM-1445] Fix Go build on Windows #1059

merged 1 commit into from
Sep 19, 2024

Conversation

coltonhurst
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1445

📔 Objective

Go builds on Windows are failing, this PR adds the needed libraries that are missing.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst self-assigned this Sep 17, 2024
@coltonhurst coltonhurst requested review from a team, Hinton and dani-garcia September 17, 2024 16:38
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd6a6aeb4-dfc5-482a-8848-751fea123f7d

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.24%. Comparing base (fb2053d) to head (f3fa27d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   58.24%   58.24%           
=======================================
  Files         197      197           
  Lines       13504    13504           
=======================================
  Hits         7865     7865           
  Misses       5639     5639           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton removed their request for review September 19, 2024 13:15
@coltonhurst coltonhurst merged commit 3ab4eef into main Sep 19, 2024
69 of 70 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1445 branch September 19, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants