Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[PM-11922] Handle apk key hash as origin" #1067

Closed

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Sep 18, 2024

Reverts #1042

Compilation fails hard on Windows, no idea why

@coroiu coroiu requested a review from dani-garcia September 18, 2024 13:34
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2a64f2dd-342d-4092-a6fa-112aa221a860

No New Or Fixed Issues Found

@coroiu coroiu closed this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.24%. Comparing base (08859a3) to head (66df0b0).

Files with missing lines Patch % Lines
crates/bitwarden-fido/src/client.rs 0.00% 7 Missing ⚠️
crates/bitwarden-uniffi/src/platform/fido2.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
+ Coverage   58.16%   58.24%   +0.08%     
==========================================
  Files         197      197              
  Lines       13523    13504      -19     
==========================================
  Hits         7865     7865              
+ Misses       5658     5639      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant