Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12576] Support publishing gradle to local maven repository #1076

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 24, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12576

📔 Objective

Support publishing to local maven repository.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia September 24, 2024 10:23
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Logo
Checkmarx One – Scan Summary & Details7359eedf-0856-4bfd-9954-6797ad0544e3

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (56fc75d) to head (997570d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   58.11%   58.27%   +0.15%     
==========================================
  Files         197      192       -5     
  Lines       13531    13486      -45     
==========================================
- Hits         7864     7859       -5     
+ Misses       5667     5627      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dani-garcia
dani-garcia previously approved these changes Sep 24, 2024
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit on the script to make it easier to run anywhere

@@ -0,0 +1,11 @@
mkdir -p ./sdk/src/main/jniLibs/{arm64-v8a,armeabi-v7a,x86_64,x86}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkdir -p ./sdk/src/main/jniLibs/{arm64-v8a,armeabi-v7a,x86_64,x86}
cd "$(dirname "$0")"
mkdir -p ./sdk/src/main/jniLibs/{arm64-v8a,armeabi-v7a,x86_64,x86}

Can we add this to the top of the file to make sure the script can be run from any directory?

I tend to run all the scripts from the root sdk dir like ./languages/kotlin/publish-local.sh if I can, and this would make it more convenient.

@Hinton Hinton merged commit 0747621 into main Sep 24, 2024
75 checks passed
@Hinton Hinton deleted the ps/android-publish-local branch September 24, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants