Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby SDK #245

Merged
merged 80 commits into from
Nov 30, 2023
Merged

Ruby SDK #245

merged 80 commits into from
Nov 30, 2023

Conversation

MaliRobot
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Ruby wrapper for Bitwarden SDK.

Code changes

First version which introduces basic functionality to interact with projects and clients.

@bitwarden-bot
Copy link

bitwarden-bot commented Sep 21, 2023

Logo
Checkmarx One – Scan Summary & Details732423e9-9b76-4f9b-9fb9-0596b402a074

No New Or Fixed Issues Found

@MaliRobot MaliRobot requested a review from a team as a code owner September 22, 2023 09:35
MaliRobot and others added 21 commits September 22, 2023 11:35
* ruby build

* fix build

* change title

* fix paths

* change ruby

* change ruby

* change ruby

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* rename lib

* rename lib

* rename lib

* rename lib

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* Update build-ruby.yml

* change ruby

* change ruby

* change ruby

* change ruby

* change ruby

* change ruby

* change ruby

* change ruby

* change ruby

* change ruby

* change ruby

* rename lib

* printout

* rename gamespec file

---------

Co-authored-by: Milos Trifunovic <[email protected]>
Co-authored-by: Miloš Trifunović <[email protected]>
- New version
- Workflow file for ruby publish
@MaliRobot MaliRobot requested review from Hinton and vgrassia November 11, 2023 10:59
@vgrassia
Copy link
Member

@Hinton Workflows look good to me.

@dani-garcia dani-garcia self-requested a review November 22, 2023 17:38
languages/ruby/bitwarden_sdk/lib/bitwarden-sdk.rb Outdated Show resolved Hide resolved
languages/ruby/examples/example.rb Outdated Show resolved Hide resolved
sig/bitwarden_sdk/bitwarden_client.rbs Outdated Show resolved Hide resolved
languages/ruby/examples/example.rb Show resolved Hide resolved
@Hinton Hinton requested a review from dani-garcia November 27, 2023 13:58
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not finding these earlier but I've been going through the PRs to ensure consistencies between the languages and found a few inconsistencies. I believe we're good once these are resolved. @dani-garcia are your concerns addressed?

languages/ruby/bitwarden_sdk/lib/bitwarden-sdk.rb Outdated Show resolved Hide resolved
languages/ruby/README.md Outdated Show resolved Hide resolved
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things on the new BitwardenSettings changes otherwise looks ready

languages/ruby/README.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel García <[email protected]>
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@dani-garcia dani-garcia merged commit b6c6532 into bitwarden:master Nov 30, 2023
54 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants