Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cross to a newer untagged release #537

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Upgrade cross to a newer untagged release #537

merged 1 commit into from
Jan 25, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 25, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The lockfile bump in #464 requires a newer rust version to build correctly. Unfortunately the latest released version of cross doesn't support newer rust versions for android To resolve this we target a newer revision.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from a team as a code owner January 25, 2024 10:11
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f31441) 51.48% compared to head (8c9f416) 51.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   51.48%   51.48%           
=======================================
  Files         163      163           
  Lines        8168     8168           
=======================================
  Hits         4205     4205           
  Misses       3963     3963           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from dani-garcia January 25, 2024 10:19
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, kinda frustrating that cross is still maintained but hasn't made a release in almost a year

@Hinton Hinton merged commit ee04e22 into main Jan 25, 2024
55 of 56 checks passed
@Hinton Hinton deleted the ps/cross-latest branch January 25, 2024 12:51
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailseb80820f-a831-4231-9af9-bf20fe98869c

Fixed Issues

Severity Issue Source File / Package
HIGH Command_Injection /languages/python/example.py: 66
HIGH Command_Injection /languages/python/example.py: 35
HIGH Missing User Instruction /Dockerfile: 23
HIGH Reflected_XSS /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 379
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 9
MEDIUM Privacy_Violation /languages/java/Example.java: 12
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 40
MEDIUM Privacy_Violation /languages/java/Example.java: 13
MEDIUM Unchecked_Input_for_Loop_Condition /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 379
MEDIUM Unpinned Actions Full Length Commit SHA /release-napi.yml: 135
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 75
MEDIUM Unpinned Actions Full Length Commit SHA /release-napi.yml: 50
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 68
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 137
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 61
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 134
MEDIUM Unpinned Actions Full Length Commit SHA /release-napi.yml: 104
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 78
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 52
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 151
MEDIUM Using Platform Flag with FROM Command /Dockerfile: 4
LOW Healthcheck Instruction Missing /Dockerfile: 23
LOW Missing_CSP_Header /about.hbs: 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants