Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3438] Vault exports #561

Merged
merged 16 commits into from
Feb 6, 2024
Merged

[PM-3438] Vault exports #561

merged 16 commits into from
Feb 6, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 30, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Vault export implementation.

New crate bitwarden-exporters which defines it's own data structure, isolating it from the other code areas. It primarily focuses on converting a data model to csv and json. Currently all data has to be decrypted independently of what is required for the export which is an area of improvement for the future.

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please add unit tests where it makes sense to do so

@bitwarden-bot
Copy link

bitwarden-bot commented Jan 30, 2024

Logo
Checkmarx One – Scan Summary & Details85d48ee5-071b-42bd-9558-22dc245a70c6

No New Or Fixed Issues Found

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (32be569) 53.77% compared to head (522e637) 57.81%.
Report is 12 commits behind head on main.

❗ Current head 522e637 differs from pull request most recent head e424da3. Consider uploading reports for the commit e424da3 to get more accurate results

Files Patch % Lines
crates/bitwarden/src/tool/exporters/mod.rs 65.02% 71 Missing ⚠️
crates/bitwarden-exporters/src/lib.rs 35.71% 9 Missing ⚠️
crates/bitwarden-exporters/src/csv.rs 99.07% 2 Missing ⚠️
...es/bitwarden/src/tool/exporters/client_exporter.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   53.77%   57.81%   +4.04%     
==========================================
  Files         165      168       +3     
  Lines        8878     9906    +1028     
==========================================
+ Hits         4774     5727     +953     
- Misses       4104     4179      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from dani-garcia February 2, 2024 14:10
@Hinton Hinton marked this pull request as ready for review February 2, 2024 14:10
crates/bitwarden/src/tool/exporters/mod.rs Show resolved Hide resolved
crates/bitwarden-exporters/src/lib.rs Show resolved Hide resolved
crates/bitwarden-exporters/src/lib.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/cipher/field.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/mod.rs Show resolved Hide resolved
crates/bitwarden-exporters/src/csv.rs Outdated Show resolved Hide resolved
crates/bitwarden-exporters/src/json.rs Outdated Show resolved Hide resolved
crates/bitwarden-exporters/src/lib.rs Outdated Show resolved Hide resolved
@Hinton Hinton requested a review from dani-garcia February 6, 2024 10:33
@Hinton Hinton merged commit 714c2d4 into main Feb 6, 2024
53 of 55 checks passed
@Hinton Hinton deleted the ps/exporters branch February 6, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants