Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement alternative login with device flow #568

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 31, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

When approving from other devices we need to support the master key flow. Also implements login with device for the CLI as a testing tool.

Before you submit

  • Please add unit tests where it makes sense to do so

@bitwarden-bot
Copy link

bitwarden-bot commented Jan 31, 2024

Logo
Checkmarx One – Scan Summary & Details7f9a1514-cb5d-4e49-8af0-46863d1d4032

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 182 lines in your changes are missing coverage. Please review.

Comparison is base (872a05b) 52.75% compared to head (da7ad8f) 52.02%.

Files Patch % Lines
crates/bitwarden/src/auth/login/auth_request.rs 0.00% 87 Missing ⚠️
...src/auth/api/request/auth_request_token_request.rs 0.00% 28 Missing ⚠️
crates/bw/src/auth/login.rs 0.00% 20 Missing ⚠️
crates/bitwarden/src/auth/client_auth.rs 0.00% 14 Missing ⚠️
crates/bitwarden/src/auth/login/password.rs 0.00% 10 Missing ⚠️
...den/src/auth/api/request/password_token_request.rs 0.00% 9 Missing ⚠️
crates/bitwarden/src/mobile/crypto.rs 35.71% 9 Missing ⚠️
crates/bw/src/main.rs 0.00% 4 Missing ⚠️
crates/bitwarden/src/client/client.rs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   52.75%   52.02%   -0.73%     
==========================================
  Files         163      165       +2     
  Lines        8381     8617     +236     
==========================================
+ Hits         4421     4483      +62     
- Misses       3960     4134     +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from dani-garcia February 1, 2024 09:50
@Hinton Hinton marked this pull request as ready for review February 1, 2024 09:50
@Hinton Hinton merged commit 2ac95f1 into main Feb 1, 2024
56 of 57 checks passed
@Hinton Hinton deleted the ps/device-login-master-key branch February 1, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants