Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docker CLI to ACR from feature branches #692

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

michalchecinski
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • .github/workflows/build-cli-docker.yml: Push the docker image always and run build on PR, and branches push without specifying path of the change

Before you submit

  • Please add unit tests where it makes sense to do so

@michalchecinski michalchecinski requested a review from a team as a code owner April 2, 2024 12:30
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Logo
Checkmarx One – Scan Summary & Details4437d065-75b5-4642-a6d5-bd1e03486bfd

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 69 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 62 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 145 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 63
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 70
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 146

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.71%. Comparing base (0b3f175) to head (5d8eb29).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   60.71%   60.71%           
=======================================
  Files         173      173           
  Lines       10513    10513           
=======================================
  Hits         6383     6383           
  Misses       4130     4130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michalchecinski michalchecinski enabled auto-merge (squash) April 2, 2024 12:36
@michalchecinski michalchecinski merged commit a408745 into main Apr 2, 2024
77 checks passed
@michalchecinski michalchecinski deleted the change-build-cli-docker branch April 2, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants