Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fastMail to use forDomain instead of url #707

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Change fastMail to use forDomain instead of url #707

merged 1 commit into from
Apr 11, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Apr 11, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

It seems the web clients use forDomain instead of url for website. This changes the SDK to send the same values.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia April 11, 2024 14:45
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details94876a11-089b-480a-bd70-082c59b781b5

No New Or Fixed Issues Found

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (b4205cc) to head (cdb8aaf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   60.77%   60.77%           
=======================================
  Files         173      173           
  Lines       10608    10608           
=======================================
  Hits         6447     6447           
  Misses       4161     4161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit e0513dc into main Apr 11, 2024
76 checks passed
@Hinton Hinton deleted the ps/fastmail branch April 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants