Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bacon config #721

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add bacon config #721

merged 2 commits into from
Apr 19, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Apr 19, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adds a bacon config which is useful when writing rustdoc. bacon doc-internal-open will re-build the doc on changes.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia April 19, 2024 12:37
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1b3279c1-ee65-4b11-9480-f092396622d3

No New Or Fixed Issues Found

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.66%. Comparing base (21ad6b2) to head (7499933).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   60.66%   60.66%           
=======================================
  Files         173      173           
  Lines       10628    10628           
=======================================
  Hits         6447     6447           
  Misses       4181     4181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this looks quite nice! Now that we're looking at dev tooling, I've been using cargo nextest to run my tests lately, as it's better at multithreading and runs a decent bit faster (plus the output is nicer to look at), it would be nice to support it here too

@Hinton Hinton merged commit dfe067e into main Apr 19, 2024
76 checks passed
@Hinton Hinton deleted the ps/bacon branch April 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants