Document developer tools #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 60.66% 60.66%
=======================================
Files 173 173
Lines 10628 10628
=======================================
Hits 6447 6447
Misses 4181 4181 ☔ View full report in Codecov by Sentry. |
Hinton
approved these changes
Apr 22, 2024
| - `bacon`: This is a CLI background code checker. We provide a configuration file with some of the | ||
| most common tasks to run (`check`, `clippy`, `test`, `doc` - run `bacon -l` to see them all). This | ||
| tool needs to be installed separately by running `cargo install bacon --locked`. | ||
| - `nexttest`: This is a new and faster test runner, capable of running tests in parallel and with a |
There was a problem hiding this comment.
Should we update bacon test to run nexttest?
There was a problem hiding this comment.
That's what I tried initially, but bacon relies on parsing the output from cargo test to show the failed test output, which didn't work correctly with cargo nextest sadly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Documented the tools we use for development. Sadly couldn't integrate
nextestintobaconas the output is too different andbaconrelies on parsing it to work. I still included it in the list for the cases where devs run it manually.I've also removed the
lto = trueinstruction from bitwarden-napi, as it was ignored in favor of the workspace setting and was producing a warning.