Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny unused async #838

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Deny unused async #838

merged 2 commits into from
Jun 13, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jun 13, 2024

📔 Objective

We currently use async on several methods that don't actually require it. This PR enables the clippy rule which will warn if any async is unnecessary. It also resolves all existing usages.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia June 13, 2024 10:11
Copy link
Contributor

github-actions bot commented Jun 13, 2024

Logo
Checkmarx One – Scan Summary & Detailsc842c5f9-7cf8-4b40-a78c-e33b54fc52be

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 19.81982% with 89 lines in your changes missing coverage. Please review.

Project coverage is 59.64%. Comparing base (3f56e58) to head (c0099fb).

Files Patch % Lines
crates/bitwarden-uniffi/src/tool/sends.rs 0.00% 15 Missing ⚠️
crates/bitwarden-uniffi/src/vault/attachments.rs 0.00% 14 Missing ⚠️
crates/bw/src/main.rs 0.00% 14 Missing ⚠️
crates/bitwarden/src/mobile/tool/client_sends.rs 0.00% 9 Missing ⚠️
...s/bitwarden/src/mobile/vault/client_attachments.rs 16.66% 5 Missing ⚠️
crates/bitwarden-uniffi/src/tool/mod.rs 0.00% 4 Missing ⚠️
crates/bitwarden-uniffi/src/vault/ciphers.rs 0.00% 4 Missing ⚠️
crates/bitwarden-uniffi/src/crypto.rs 0.00% 3 Missing ⚠️
crates/bitwarden-uniffi/src/vault/folders.rs 0.00% 3 Missing ⚠️
crates/bitwarden/src/mobile/client_crypto.rs 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   59.24%   59.64%   +0.39%     
==========================================
  Files         186      186              
  Lines       12426    12305     -121     
==========================================
- Hits         7362     7339      -23     
+ Misses       5064     4966      -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit 6c18348 into main Jun 13, 2024
104 checks passed
@Hinton Hinton deleted the ps/deny-unused-async branch June 13, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants