Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non blocking passkeys #867

Closed
wants to merge 1 commit into from
Closed

Non blocking passkeys #867

wants to merge 1 commit into from

Conversation

dani-garcia
Copy link
Member

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 1cacb3da-fbaf-45d2-8851-5006239f9bbd

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 77 lines in your changes missing coverage. Please review.

Project coverage is 55.77%. Comparing base (569e1fc) to head (80db14f).
Report is 67 commits behind head on main.

Files Patch % Lines
crates/bitwarden-uniffi/src/platform/fido2.rs 0.00% 77 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   56.00%   55.77%   -0.23%     
==========================================
  Files         193      193              
  Lines       12607    12657      +50     
==========================================
  Hits         7060     7060              
- Misses       5547     5597      +50     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@dani-garcia dani-garcia force-pushed the ps/non-blocking-passkey branch from 60c8e20 to 80db14f Compare July 2, 2024 17:00
@dani-garcia dani-garcia changed the title [WIP] Non blocking passkeys Non blocking passkeys Jul 2, 2024
@dani-garcia dani-garcia marked this pull request as ready for review July 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant