Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --locked in installation docs #896

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

dani-garcia
Copy link
Member

🎟️ Tracking

📔 Objective

Using cargo install bws can cause issues if any minor dependency update has breaking changes. This was the case with #888.

By using --locked, we make cargo use the Cargo.lock file in the package, ensuring any builds use the same dependencies as we tested with.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dani-garcia dani-garcia requested a review from Hinton July 11, 2024 11:04
@dani-garcia dani-garcia requested a review from a team as a code owner July 11, 2024 11:04
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1680e67a-fe65-4b3f-99ea-451628f4b8d1

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.60%. Comparing base (5d11290) to head (631a760).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #896   +/-   ##
=======================================
  Coverage   57.60%   57.60%           
=======================================
  Files         193      193           
  Lines       13076    13076           
=======================================
  Hits         7533     7533           
  Misses       5543     5543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dani-garcia dani-garcia merged commit de2a64c into main Jul 11, 2024
104 checks passed
@dani-garcia dani-garcia deleted the ps/use-locked-install branch July 11, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants