Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1327] Fix PYO3 Deprecation #897

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[SM-1327] Fix PYO3 Deprecation #897

merged 2 commits into from
Jul 17, 2024

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Jul 11, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1327

📔 Objective

Update all PYO3 dependencies and fix the necessary deprecation notices.

Thanks @Thomas-Avery and @dani-garcia for the collaboration!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst self-assigned this Jul 11, 2024
Copy link
Contributor

github-actions bot commented Jul 11, 2024

Logo
Checkmarx One – Scan Summary & Details61924135-1c34-4794-bbf3-8ff77976d3ab

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.60%. Comparing base (5d11290) to head (e2d3c4b).

Files Patch % Lines
crates/bitwarden-py/src/python_module.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   57.60%   57.60%           
=======================================
  Files         193      193           
  Lines       13076    13076           
=======================================
  Hits         7533     7533           
  Misses       5543     5543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coltonhurst coltonhurst marked this pull request as ready for review July 11, 2024 12:25
@coltonhurst coltonhurst requested a review from a team July 11, 2024 12:37
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@coltonhurst coltonhurst merged commit 740895c into main Jul 17, 2024
105 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1327 branch July 17, 2024 15:28
@coltonhurst coltonhurst changed the title SM-1327: Fix PYO3 Deprecation [SM-1327] Fix PYO3 Deprecation Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants