Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1338] Add the ability to edit unassigned secrets #906

Merged
merged 7 commits into from
Jul 19, 2024
Merged

[SM-1338] Add the ability to edit unassigned secrets #906

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
175fcc7
Add the ability to update unassigned secrets
Thomas-Avery Jul 16, 2024
7a2f237
Update changelog
Thomas-Avery Jul 16, 2024
f40009e
Merge branch 'main' into sm/sm-1338
Thomas-Avery Jul 16, 2024
70f7a17
simplify matches
Thomas-Avery Jul 17, 2024
4e33b3a
Merge branch 'main' into sm/sm-1338
Thomas-Avery Jul 17, 2024
3a7645f
Merge branch 'main' into sm/sm-1338
Thomas-Avery Jul 18, 2024
c520d91
Merge branch 'main' into sm/sm-1338
Thomas-Avery Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/bws/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Added

- The ability to edit unassigned secrets with direct permissions. (#906)

### Removed

- The deprecated `action type` commands are now removed. Please use `type action` instead. (#836)
Expand Down
2 changes: 1 addition & 1 deletion crates/bws/src/command/secret.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
Some(id) => Some(vec![id]),
Thomas-Avery marked this conversation as resolved.
Show resolved Hide resolved
None => match old_secret.project_id {
Some(id) => Some(vec![id]),
None => bail!("Editing a secret requires a project_id."),
None => None,

Check warning on line 178 in crates/bws/src/command/secret.rs

View check run for this annotation

Codecov / codecov/patch

crates/bws/src/command/secret.rs#L178 

Added line #L178 was not covered by tests
},
},
})
Expand Down
Loading