[SM-1370] Update QuickType version #926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1370
📔 Objective
The purpose of this PR is to update the
QuickType
version.Most language generated schemas were not effected.
C++
A minor change in the error message for enum parsing.
to
Go
Has several breaking changes.
omit-empty
Previously, the
omit-empty
feature was enabled by default.QuickType's description:
If set, all non-required objects will be tagged with ",omitempty"
For example, the
SecretsSyncRequest
structLastSyncedDate
is optional and usesemitempty
.To continue this behavior, I added and enabled it in the render options
support/scripts/schemas.ts
.just-types-and-package & time
Previously, model properties that were
DateTime
types in Bitwarden server models were translated to Gostring
properties.With this newer version of QuickType these
DateTime
properties are nowtime.Time
in Go.This required changes to the Sync function
languages/go/secrets.go
.With the
just-types-and-package
render option,import "time"
is added to the file at the first occurrence of atime.Time
property.This is most likely a bug and causes build errors.
Removing the
just-types-and-package
render option fixes this problem and has the import moved to the top of the file.This does cause adding some unnecessary marshal & un-marshal functions, that won't be used, into the
schema.go
file.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes