-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1399] Update the README for Windows on ARM #942
Conversation
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
=======================================
Coverage 58.45% 58.45%
=======================================
Files 194 194
Lines 13358 13358
=======================================
Hits 7808 7808
Misses 5550 5550 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see the Python requirement in the ring docs, but yeah the clang requirement is true.
Rather than full visual studio I think we can recommend installing the Visual Studio Build Tools which should be somewhat lighter than a full visual studio install. You still need to manually select the clang
component and add it to the PATH though.
Do we know if those build tools include Clang? I attempted this the first time around in my tests and I couldn't find Clang in the filesystem until after I installed the full suite. I would much rather only recommend Build Tools because it is much smaller as you mentioned. Edit: And yes, I think Python is required for something else, not ring. |
I think for both the build tools and the full visual studio package you have to manually select |
Ah, I did have the wrong download. Thanks @dani-garcia! Updated in 941fbae |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1399
📔 Objective
Just
cargo build
is not sufficient for building the SDK on Windows on ARM. We should add clarity to what is required so thatcargo build
will run successfully.Python is required. Clang is also required for ring (more info here).
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes