-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1413] Temporary PR to Showcase 'hyper' Error #955
Conversation
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
==========================================
- Coverage 58.45% 58.34% -0.11%
==========================================
Files 194 194
Lines 13358 13382 +24
==========================================
Hits 7808 7808
- Misses 5550 5574 +24 โ View full report in Codecov by Sentry. |
โฆs to a shared BitwardenClient * bitwarden/sdk-sm#955
## ๐๏ธ Tracking https://bitwarden.atlassian.net/browse/SM-1413 ## ๐ Objective ### The Issue Through the C FFI, we were running into concurrency issues with multiple Tokio runtimes. A draft PR showing the concurrency issue with instructions can be found [here](#955). ### The Fix This PR fixes this issue for `bitwarden-c` and `bitwarden-py`, by preserving the runtime. Thanks @dani-garcia for the fix and working together on this one! ### Extra This also refactors the `AccessTokenLogin` type as a follow up for testing purposes for Go as initiated by [this](#953) PR. ## โฐ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## ๐ฆฎ Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - ๐ (`:+1:`) or similar for great changes - ๐ (`:memo:`) or โน๏ธ (`:information_source:`) for notes or general info - โ (`:question:`) for questions - ๐ค (`:thinking:`) or ๐ญ (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - ๐จ (`:art:`) for suggestions / improvements - โ (`:x:`) orโ ๏ธ (`:warning:`) for more significant problems or concerns needing attention - ๐ฑ (`:seedling:`) or โป๏ธ (`:recycle:`) for future improvements or indications of technical debt - โ (`:pick:`) for minor or nitpick changes
The fix has been merged: #981 |
โฆs to a shared BitwardenClient * bitwarden/sdk-sm#955
๐๏ธ Tracking
https://bitwarden.atlassian.net/browse/SM-1413
๐ Objective
๐จ Do Not Merge This PR ๐จ
The goal of this PR is to allow a developer to easily reproduce a potential bug with hyper that we are running into.
Description
When running concurrent requests using the same client from the Go SDK binding, execution stops for at least one of the threads at runtime with the following error:
runtime dropped the dispatch task
.Replication Steps
cargo build
from rootnpm run schemas
from rootsdk/target/debug/libbitwarden_c.a
to thesdk/languages/go/internal/cinterface/lib/{arch}
folder, where{arch}
is your CPU architecture.darwin-arm64
sdk/languages/go/example/example.go
file:OrganizationId
AccessToken
statePath
sdk/languages/go/example
, rungo build
sdk/languages/go/example
, run./example > go-log.txt 2>&1
Open the
go-log.txt
file and you should find something similar to the following (certain data redacted and replaced withx
):โฐ Reminders before review
team
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes