Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose exporters for mobile #612

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Expose exporters for mobile #612

merged 1 commit into from
Feb 13, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 13, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

We forgot to expose the ClientsExporters in the uniffi bindings.

Before you submit

  • Please add unit tests where it makes sense to do so

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details7fde3d3f-b3cd-475c-9ce5-3d9553302839

No New Or Fixed Issues Found

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (16f4cc5) 59.41% compared to head (23a9c62) 59.40%.

Files Patch % Lines
crates/bitwarden-uniffi/src/lib.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   59.41%   59.40%   -0.02%     
==========================================
  Files         171      171              
  Lines       10342    10345       +3     
==========================================
  Hits         6145     6145              
- Misses       4197     4200       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit 5a94119 into main Feb 13, 2024
57 of 58 checks passed
@Hinton Hinton deleted the ps/uniffi-exporters branch February 13, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants