Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1785] Update release pipeline for ruby sdk #614

Merged

Conversation

michalchecinski
Copy link
Contributor

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

https://bitwarden.atlassian.net/browse/DEVOPS-1785

Code changes

  • .github/workflows/build-rust-cross-platform.yml: Trigger on push to main, rc and hotfix-rc
  • .github/workflows/generate_schemas.yml Trigger on push to main, rc and hotfix-rc
  • .github/workflows/publish-ruby.yml Publish ruby only on workflow dispatch get the artifacts from build workflows instead of triggering them
  • .github/workflows/version-bump.yml Add ruby sdk to bump version workflow

Before you submit

  • Please add unit tests where it makes sense to do so

@michalchecinski michalchecinski requested a review from a team as a code owner February 16, 2024 11:37
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 16, 2024

Logo
Checkmarx One – Scan Summary & Details1b4171d5-846f-4543-9786-183c26eb7c95

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-ruby.yml: 51 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 53

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0366e86) 59.40% compared to head (b560637) 59.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         171      171           
  Lines       10345    10345           
=======================================
  Hits         6145     6145           
  Misses       4200     4200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mimartin12
mimartin12 previously approved these changes Feb 16, 2024
mimartin12
mimartin12 previously approved these changes Feb 21, 2024
@michalchecinski michalchecinski merged commit 412ae78 into main Feb 22, 2024
61 checks passed
@michalchecinski michalchecinski deleted the DEVOPS-1785-Update-release-pipeline-for-Ruby-SDK branch February 22, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants