-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md #658
Update CHANGELOG.md #658
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
- Coverage 60.53% 60.39% -0.15%
==========================================
Files 172 172
Lines 10527 10553 +26
==========================================
Hits 6373 6373
- Misses 4154 4180 +26 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, anything else we may be missing @bitwarden/team-secrets-manager-dev ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should discuss if this is a breaking change (example discussion in the wild):
- The MSRV for
bws
was updated to1.71.0
: Update MSRV to 1.71 and add CI test #589
I also think we should consider adding these items to the changelog:
bws
mac signing support: [DEVOPS-1333] Add code signing to the macOS bws CLI #535- The output option added back in the help menu: SM-1066: Add back the Output option to the help menu in bws #477
- We now use rustls on non-wasm platforms: [PM-4269] Use rustls on non-wasm platforms #374
Co-authored-by: Oscar Hinton <[email protected]>
Co-authored-by: Oscar Hinton <[email protected]>
Co-authored-by: Oscar Hinton <[email protected]>
Co-authored-by: Oscar Hinton <[email protected]>
Co-authored-by: Oscar Hinton <[email protected]>
Type of change
Objective
Update changelog to mention the
bws
Docker image