Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #658

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Update CHANGELOG.md #658

merged 10 commits into from
Mar 18, 2024

Conversation

tangowithfoxtrot
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update changelog to mention the bws Docker image

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (ec54a89) to head (8add30c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   60.53%   60.39%   -0.15%     
==========================================
  Files         172      172              
  Lines       10527    10553      +26     
==========================================
  Hits         6373     6373              
- Misses       4154     4180      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review March 12, 2024 15:03
@bitwarden-bot
Copy link

bitwarden-bot commented Mar 12, 2024

Logo
Checkmarx One – Scan Summary & Details30537760-3342-4882-9388-1024b4eff60e

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /release-go.yml: 77

Copy link
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, anything else we may be missing @bitwarden/team-secrets-manager-dev ?

Thomas-Avery
Thomas-Avery previously approved these changes Mar 12, 2024
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should discuss if this is a breaking change (example discussion in the wild):

I also think we should consider adding these items to the changelog:

crates/bws/CHANGELOG.md Outdated Show resolved Hide resolved
crates/bws/CHANGELOG.md Outdated Show resolved Hide resolved
crates/bws/CHANGELOG.md Outdated Show resolved Hide resolved
crates/bws/CHANGELOG.md Outdated Show resolved Hide resolved
crates/bws/CHANGELOG.md Outdated Show resolved Hide resolved
@tangowithfoxtrot tangowithfoxtrot merged commit b6d36ea into main Mar 18, 2024
69 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the tangowithfoxtrot-patch-1 branch March 18, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants