[PM-10600] Unit Test coverage and refactor for Push Notifications #4494
Triggered via pull request
November 9, 2024 15:48
mzieniukbw
mzieniukbw
opened
#5011
Status
Success
Total duration
44m 28s
Artifacts
–
scan.yml
on: pull_request_target
Check PR run
/
Check
3s
Annotations
10 warnings
|
Quality scan:
src/Core/Models/Mail/Provider/ProviderInitiateDeleteModel.cs#L11
'ProviderInitiateDeleteModel.WebVaultUrl' hides inherited member 'BaseMailModel.WebVaultUrl'. Use the new keyword if hiding was intended.
|
|
Quality scan:
src/Core/Models/Mail/Provider/ProviderInitiateDeleteModel.cs#L14
'ProviderInitiateDeleteModel.SiteName' hides inherited member 'BaseMailModel.SiteName'. Use the new keyword if hiding was intended.
|
|
Quality scan:
src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/UpdateOrganizationUserCommand.cs#L121
Possible null reference argument for parameter 'collections' in 'Task IOrganizationUserRepository.ReplaceAsync(OrganizationUser obj, IEnumerable<CollectionAccessSelection> collections)'.
|
|
Quality scan:
src/Core/Billing/Services/Implementations/PaymentHistoryService.cs#L15
Parameter 'logger' is unread.
|
|
Quality scan:
src/Core/Services/Implementations/MultiServiceMailDeliveryService.cs#L14
Make sure that using this pseudorandom number generator is safe here. (https://rules.sonarsource.com/csharp/RSPEC-2245)
|
|
Quality scan:
src/Core/Utilities/CoreHelpers.cs#L32
Make sure that using this pseudorandom number generator is safe here. (https://rules.sonarsource.com/csharp/RSPEC-2245)
|
|
Quality scan:
src/Core/Services/Implementations/UserService.cs#L170
'_currentContext' is null on at least one execution path. (https://rules.sonarsource.com/csharp/RSPEC-2259)
|
|
Quality scan:
src/Core/Services/Implementations/UserService.cs#L181
'_currentContext' is null on at least one execution path. (https://rules.sonarsource.com/csharp/RSPEC-2259)
|
|
Quality scan:
src/Core/Services/Implementations/MailKitSmtpMailDeliveryService.cs#L73
Enable server certificate validation on this SSL/TLS connection (https://rules.sonarsource.com/csharp/RSPEC-4830)
|
|
Quality scan:
src/Core/OrganizationFeatures/OrganizationSubscriptions/AddSecretsManagerSubscriptionCommand.cs#L77
'plan' is null on at least one execution path. (https://rules.sonarsource.com/csharp/RSPEC-2259)
|