[PM-10873] Updated errors thrown when creating organization on selfhost to be more specific

[cturnbull-bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10873

📔 Objective

Updated the self-hosted server's validation when uploading a new license. Updates are to ensure that the plan specified on the license exists, is not disabled, and also that the license type is accurate.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.58%. Comparing base (702a81b) to head (b6907db).

Files with missing lines	Patch %	Lines
...le/Services/Implementations/OrganizationService.cs	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5007      +/-   ##
==========================================
- Coverage   42.58%   42.58%   -0.01%     
==========================================
  Files        1406     1406              
  Lines       65074    65081       +7     
  Branches     5962     5963       +1     
==========================================
  Hits        27715    27715              
- Misses      36131    36138       +7     
  Partials     1228     1228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 700fd78e-753c-4a05-a3bd-369dfa038090

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 68
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 102
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 89
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 159
	CSRF	/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 61
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 102
	Log_Forging	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 102

[vincentsalucci]

⛏️ Would really love to see some unit tests around the newly added error paths.

SAST scan failed

Looks good otherwise!