Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10600] Unit Test coverage and refactor for Push Notifications #5011

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

PM-10600: Throw Xunit assert exception when sending request via BaseI…

7bea641
Select commit
Loading
Failed to load commit list.
Draft

[PM-10600] Unit Test coverage and refactor for Push Notifications #5011

PM-10600: Throw Xunit assert exception when sending request via BaseI…
7bea641
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 9, 2024 in 0s

43.03% (+0.25%) compared to 31316ee

View this Pull Request on Codecov

43.03% (+0.25%) compared to 31316ee

Details

Codecov Report

Attention: Patch coverage is 38.29787% with 29 lines in your changes missing coverage. Please review.

Project coverage is 43.03%. Comparing base (31316ee) to head (7bea641).

Files with missing lines Patch % Lines
src/Notifications/AzureQueueHostedService.cs 0.00% 12 Missing ⚠️
src/Notifications/HubHelpers.cs 63.15% 7 Missing ⚠️
src/Notifications/Controllers/SendController.cs 0.00% 6 Missing ⚠️
...vices/Implementations/BaseIdentityClientService.cs 0.00% 2 Missing and 1 partial ⚠️
src/Notifications/Startup.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           km/pm-10600    #5011      +/-   ##
===============================================
+ Coverage        42.78%   43.03%   +0.25%     
===============================================
  Files             1391     1389       -2     
  Lines            64902    64869      -33     
  Branches          5960     5960              
===============================================
+ Hits             27769    27918     +149     
+ Misses           35903    35714     -189     
- Partials          1230     1237       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov