Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blazor proof of concept #5040

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Blazor proof of concept #5040

wants to merge 9 commits into from
+743 −1

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.69198% with 169 lines in your changes missing coverage. Please review.

Project coverage is 42.62%. Comparing base (1d3188d) to head (8d5d421).
Report is 99 commits behind head on main.

Files with missing lines Patch % Lines
src/Admin/AdminConsole/Components/App.razor.cs 0.00% 71 Missing ⚠️
src/Admin/Components/Navigation/NavItem.razor 0.00% 29 Missing ⚠️
...IdentityRevalidatingAuthenticationStateProvider.cs 0.00% 20 Missing ⚠️
src/Admin/AdminConsole/Components/App.razor 0.00% 14 Missing ⚠️
...ts/Pages/Organizations/ListOrganizationsPage.razor 64.86% 8 Missing and 5 partials ⚠️
...Pages/Organizations/ListOrganizationsPage.razor.cs 78.57% 6 Missing and 3 partials ⚠️
src/Admin/Startup.cs 0.00% 8 Missing ⚠️
.../Admin/Components/Navigation/NavDropDownItem.razor 0.00% 4 Missing ⚠️
src/Admin/Components/BitPage.razor.cs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5040      +/-   ##
==========================================
+ Coverage   41.75%   42.62%   +0.87%     
==========================================
  Files        1363     1421      +58     
  Lines       63915    65323    +1408     
  Branches     5853     5989     +136     
==========================================
+ Hits        26686    27845    +1159     
- Misses      36026    36228     +202     
- Partials     1203     1250      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 8b859853-6c54-44f7-b693-6c1e712fbb39

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Passwords And Secrets - Generic Password /test-database.yml: 185 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 80 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 69 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 105 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 189 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 182 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 111 Query to find passwords and secrets in infrastructure code.
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 537 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 603 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 61 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 72 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 100 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 603 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 92 Attack Vector
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 200 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 160 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/NotificationHubPushNotificationService.cs: 208 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/NotificationHubPushNotificationService.cs: 205 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 217 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 208 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 119 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 207 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 582 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 548 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /_move_finalization_db_scripts.yml: 27 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /cleanup-rc-branch.yml: 21 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 631 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 104 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 515 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 60 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /_move_finalization_db_scripts.yml: 103 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Heap_Inspection /src/Core/Constants.cs: 129 Attack Vector
LOW Log_Forging /src/Api/Controllers/PushController.cs: 71 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 170 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 155 Attack Vector
LOW Unpinned Actions Full Length Commit SHA /build.yml: 548 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 515 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 631 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 60 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 104 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 119 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 582 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Use_Of_Hardcoded_Password /src/Core/Constants.cs: 129 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 68
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 606
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 606
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 606
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 606
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 548
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 106
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 217
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 208
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 160
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 191
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 616
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 96
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 579
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 160
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 664
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 220
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 153
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 168
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 545
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 173
LOW Log_Forging /src/Api/Controllers/PushController.cs: 71
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 158
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 168
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 160
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 96
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliykat eliykat Awaiting requested review from eliykat

@jrmccannon jrmccannon Awaiting requested review from jrmccannon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonashendrickx