Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA-689/BEEEP-public-api-GET-subscription-details #5041

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aj-bw
Copy link
Member

@aj-bw aj-bw commented Nov 15, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/QA-689

📔 Objective

Add a GET operation to the Organization Subscription endpoint to allow retrieving subscription details via the Public API. re organized the classes into Request and Response directories to follow patterns throughout the server project.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@aj-bw aj-bw requested a review from a team as a code owner November 15, 2024 15:17
@aj-bw aj-bw changed the title added GET operation to org subscription endpoint QA-689/BEEEP-public-api-GET-subscription-details Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 43.06%. Comparing base (eee7494) to head (47c89d8).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...lling/Public/Controllers/OrganizationController.cs 0.00% 26 Missing ⚠️
...se/OrganizationSubscriptionDetailsResponseModel.cs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5041      +/-   ##
==========================================
+ Coverage   42.68%   43.06%   +0.37%     
==========================================
  Files        1411     1415       +4     
  Lines       65131    64850     -281     
  Branches     5969     5926      -43     
==========================================
+ Hits        27804    27929     +125     
+ Misses      36082    35687     -395     
+ Partials     1245     1234      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Logo
Checkmarx One – Scan Summary & Detailsf1c9a5fb-70cf-46c0-ace1-c2f8bad43c70

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 97 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 97 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 97 Attack Vector
LOW Unsafe_Use_Of_Target_blank /src/Admin/AdminConsole/Views/Providers/Edit.cshtml: 103 Attack Vector
LOW Unsafe_Use_Of_Target_blank /src/Admin/AdminConsole/Views/Providers/Edit.cshtml: 90 Attack Vector

Fixed Issues

Severity Issue Source File / Package
LOW Unsafe_Use_Of_Target_blank /src/Core/MailTemplates/Handlebars/FamiliesForEnterprise/FamiliesForEnterpriseRemovedFromFamilyUser.html.hbs: 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants