Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Flag] [Desktop] Build logic to provide credentials to OS on sync #5052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Nov 20, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Add feature flag for the macOS native autofill credential sync

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

LaunchDarkly flag references

๐Ÿ” 1 flag added or modified

Name Key Aliases found Info
MacOS Native Credential Sync macos-native-credential-sync

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 43.05%. Comparing base (77cde50) to head (f3e814d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5052   +/-   ##
=======================================
  Coverage   43.05%   43.05%           
=======================================
  Files        1412     1412           
  Lines       64770    64770           
  Branches     5919     5919           
=======================================
  Hits        27888    27888           
  Misses      35649    35649           
  Partials     1233     1233           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.


๐Ÿšจ Try these New Features:

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ fbf12fc4-d4c2-480e-812c-b10a6638e26c

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant