Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10317] Email Users For Org Claiming Domain #5094

Open
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Nov 27, 2024

๐ŸŽŸ๏ธ Tracking

PM-10317

๐Ÿ“” Objective

This will send out emails to users when an org claims the domain they belong to.

๐Ÿ“ธ Screenshots

User Notification
image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

jrmccannon and others added 30 commits November 7, 2024 15:50
# Conflicts:
#	src/Api/AdminConsole/Models/Response/Organizations/CommandResult.cs
#	src/Core/AdminConsole/OrganizationFeatures/Policies/PolicyValidators/SingleOrgPolicyValidator.cs
โ€ฆevokeNonCompliantOrganizationUserCommand.cs

Co-authored-by: Rui Tomรฉ <[email protected]>
โ€ฆation. Adding unknown type to event system user. Adding optional parameter to SaveAsync in policy service in order to pass in event system user.
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ cb323c3b-923d-478d-95ba-509b99676426

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 455 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 5 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 106
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 238
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 362
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 345
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 264
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 306

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 18 lines in your changes missing coverage. Please review.

Project coverage is 43.14%. Comparing base (1b75e35) to head (78f1159).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../Services/Implementations/HandlebarsMailService.cs 0.00% 12 Missing โš ๏ธ
...nizationDomains/VerifyOrganizationDomainCommand.cs 90.00% 0 Missing and 2 partials โš ๏ธ
...Console/Controllers/OrganizationUsersController.cs 0.00% 1 Missing โš ๏ธ
...OrganizationUsers/RemoveOrganizationUserCommand.cs 98.91% 0 Missing and 1 partial โš ๏ธ
...els/Mail/ClaimedDomainUserNotificationViewModel.cs 0.00% 1 Missing โš ๏ธ
...re/Services/NoopImplementations/NoopMailService.cs 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5094      +/-   ##
==========================================
+ Coverage   43.10%   43.14%   +0.04%     
==========================================
  Files        1424     1426       +2     
  Lines       65055    65124      +69     
  Branches     5957     5965       +8     
==========================================
+ Hits        28043    28100      +57     
- Misses      35758    35770      +12     
  Partials     1254     1254              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants