Nick fix controller light feedback #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed and last sent value as the API already does this for us
|
APC40mkII and LaunchPadPro looks good to me. |
abique
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call setColorToStateFunction, setBackgroundLight, use onUpdateHardware and provide some sensible getVisualState implentation so we can see light state in the simulator. This is needed so that when user make a manual mapping in Bitwig Studio to some toggle value in the application that we show that correctly on the control's background light.
Also do some code clean up and remove caching of the output of led states as this is managed by Bitwig Studio