Thomas/arturia keylab mk ii show remote control values #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickJAllen
reviewed
Jan 17, 2024
| if (parameter.exists().get()) | ||
| showNotificationOnDisplay(parameter.name(), parameter.displayedValue()); | ||
| }); | ||
| layer.bind(mEncoders[i], showNotificationAction); |
There was a problem hiding this comment.
is it possible the hardware control is mapped to something else than the parameter?
There was a problem hiding this comment.
Also why are we not just binding some text display computer to the current parameter to update the text display?
NickJAllen
reviewed
Jan 18, 2024
| encoder.isUpdatingTargetValue().markInterested(); | ||
| encoder.targetName().markInterested(); | ||
| encoder.targetDisplayedValue().markInterested(); | ||
| encoder.isBeingTouched().markInterested(); |
There was a problem hiding this comment.
Is this line strictly necessary? I don't see any use of the isBeingTouched value anywhere. Or am I just missing it?
NickJAllen
reviewed
Jan 18, 2024
|
|
||
| private void showNotificationOnDisplay(final StringValue topRowText, final StringValue bottomRowText) | ||
| { | ||
| final int notificationDurationInMs = 500; |
There was a problem hiding this comment.
One minor change. Maybe we can instead just have a pointer to the ConttinuousHardwareControl that we are adjusting rather than having a top and bottom row text?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.