Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-js fixes cherrypick to staging #2507

Merged
merged 10 commits into from
Aug 17, 2023
Merged

Non-js fixes cherrypick to staging #2507

merged 10 commits into from
Aug 17, 2023

Conversation

TheDancingClown
Copy link
Contributor

πŸ“ A short description of the changes

  • Non-js fixes cherrypick to staging

πŸ”— Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

βœ… Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@TheDancingClown TheDancingClown changed the base branch from main to staging August 17, 2023 09:12
@Lubosky Lubosky merged commit c5a27b8 into staging Aug 17, 2023
7 checks passed
@Lubosky Lubosky deleted the js-fixes-cherrypick branch August 17, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants