Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds message for previous winners of trade within 5 years #2508

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

TheDancingClown
Copy link
Contributor

📝 A short description of the changes

  • There should be an additional message for previous winners of International Trade if they have won within the last 5 years. This builds upon the previously used data-year-value to add further checks and add a message if the year selected is within 5 years of the current year.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Screenshot 2023-08-17 at 11 16 07

@DaniBitZesty DaniBitZesty merged commit 905543b into main Aug 18, 2023
@DaniBitZesty DaniBitZesty deleted the previous-winner-message branch August 18, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants