Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessor side - accessibility tweaks #2556

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Assessor side - accessibility tweaks #2556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0fa949
Fix level headings for judges
DaniBitZesty Aug 30, 2023
1e4166a
Add span with description of flags for accessibility purposes
DaniBitZesty Aug 30, 2023
15a04aa
Correct list items in previos applications section
DaniBitZesty Aug 31, 2023
9f7c371
Add visuallyhidden label to form input for 'Attach document'
DaniBitZesty Aug 31, 2023
4eb5774
Add unique id to flag checkbox
DaniBitZesty Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/helpers/form_answer_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ def application_flags(fa, subject = nil)

if comments_count > 0
content_tag :span, class: "icon-flagged #{flag_type}" do
content_tag :span, class: "flag-count" do
"#{current_user_class} flags: ".html_safe +
content_tag(:span, class: "flag-count") do
comments_count.to_s
end
end
Expand Down
1 change: 1 addition & 0 deletions app/views/admin/form_answer_attachments/_form.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
span[aria-hidden="true"] ×

.attachment-link.if-js-hide
= form.label :file, "Attach document", class: "visuallyhidden"
= form.file_field :file

.form-group
Expand Down
2 changes: 1 addition & 1 deletion app/views/admin/form_answers/_comment.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
authenticity_token: true) do |f|

label.if-js-hide Flag
= f.check_box :flagged, class: "flag-comment-checkbox if-js-hide"
= f.check_box :flagged, class: "flag-comment-checkbox if-js-hide", id: "flag-comment-#{comment.id}"
.comment-action
= l comment.created_at, format: :date_at_time
span.divider •
Expand Down
3 changes: 2 additions & 1 deletion app/views/admin/form_answers/_previous_applications_section.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@
- else
= application.award_type_and_year
- else
' None
li
' None
2 changes: 1 addition & 1 deletion app/views/judge/case_summaries/index.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

.downloads-page
.downloads-page__section
h3
h2
' Case Summaries
ul.download-list
- FormAnswer::AWARD_TYPE_FULL_NAMES.select { |key, value| current_judge.assigned_award_types.include?(key) }.each do |key, value|
Expand Down
Loading