Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessible autocomplete initialization [staging] #2558

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented Aug 31, 2023

📝 A short description of the changes

Cherry-picked from #2557
If the field is added dynamically, autocomplete is not initialized properly. Instead the HTML is just copied so it looks like autocomplete but without proper functionality. Initialization then only duplicates the field. So as a solution we just check for any .custom-select select tag, remove already copied autocomplete HTML and re-initialize.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@Lubosky Lubosky merged commit e129e01 into staging Aug 31, 2023
6 checks passed
@Lubosky Lubosky deleted the accessible-autocomplete-initialize-staging branch August 31, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant