Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Production] FIX: Proc questions not pulling data to reports #2623

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented Oct 4, 2023

📝 A short description of the changes

Cherry-picked from #2618

There were couple of changes within the last year applications where we changed how values to some questions are filled. These changes need to be reflect also in reports as some of them are now pulling blank data (mostly innovation).

This PRR contains fix to fix how some data are fetched within entries-report for innovation (Employees, Turnover...). Probably would be better to figure if this report cannot be done a little better.

🔗 Link to the relevant story (or stories)

Asana card here: https://app.asana.com/0/1200504523179343/1205630632588926/f

:shipit: Deployment implications

None.

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@Lubosky Lubosky merged commit 048c29a into production Oct 5, 2023
@Lubosky Lubosky deleted the innovation-entries-report-production branch October 5, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant