Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Financial Summary tables fixes and improvements #2923

Merged
merged 2 commits into from
May 10, 2024

Conversation

dreamfall
Copy link
Contributor

📝 A short description of the changes

  • unify output format for all numbers displayed both in PDFs and on the frontend
  • fix incorrect labels displayed for innovation award financial summary tables

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

image image

@dreamfall dreamfall merged commit d074bdf into main May 10, 2024
12 checks passed
@dreamfall dreamfall deleted the fin-summary-pdf-feedback branch May 10, 2024 13:41
@TheDancingClown TheDancingClown mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants