Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts title input to a dropdown in contact details #2932

Merged
merged 2 commits into from
May 22, 2024

Conversation

TheDancingClown
Copy link
Contributor

@TheDancingClown TheDancingClown commented May 16, 2024

📝 A short description of the changes

  • For head of business and press contact details KAO wish to force the user to select from an approved list of titles. We first add the list as a constant to the User model in case we wish to validate User titles in the future.
  • We add a condition to the sub_fields_question view to render a select if the :title sub_field_key is present.
  • We add a placeholder which will be selected if the title is not found in the list. The placeholder option is disabled to prevent users selecting.
  • We changed the input field for admin head of organisation and press contact details to a select and include a blank option for when the title is missing.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Screenshot 2024-05-22 at 09 09 31 Screenshot 2024-05-22 at 09 10 06 Screenshot 2024-05-22 at 09 10 36

@TheDancingClown TheDancingClown marked this pull request as ready for review May 22, 2024 08:08
@TheDancingClown TheDancingClown requested a review from dreamfall May 22, 2024 08:08
@TheDancingClown TheDancingClown merged commit 4b28268 into main May 22, 2024
10 of 11 checks passed
@TheDancingClown TheDancingClown deleted the title-dropdown branch May 22, 2024 10:18
@TheDancingClown TheDancingClown mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants