Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference (nickname) field mandatory for Innovation & PO applications #2974

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented Jun 21, 2024

📝 A short description of the changes

Made reference (nickname) field mandatory for Innovation & PO applications. Adding required to the input should be enough for now along with backend validation and should work OK also without JS.

Added also rake task to backfill reference (nickname) for applications where its missing.

To run the task use command bundle exec rake form_answers:populate_nickname

🔗 Link to the relevant story (or stories)

Asana card here: https://app.asana.com/0/1200504523179345/1207631171095194/f

:shipit: Deployment implications

None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

CleanShot 2024-06-21 at 17 35 21

@Lubosky Lubosky force-pushed the reference-field branch 2 times, most recently from bb087cd to 9aba4de Compare June 24, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants