Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixes for accessibility after QA #3144

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Fix: Fixes for accessibility after QA #3144

merged 4 commits into from
Nov 18, 2024

Conversation

TheDancingClown
Copy link
Contributor

📝 A short description of the changes

Some additional accessibility fixes after QA testing. After testing it was found the palace attendee forms had multiple errors for duplicated or missing labels. This was caused by generating two forms for javascript and non-javascript (where we needed multiple attendee in the past). Most errors are fixed by only prebuilding the palace_attendee once and adding an index to the labels, however this code has been commented out while we only need 1 palace attendee. We should look at moving this logic to the controller if the situation changes.

  • Adds missing labels on admin and assessor application appraisal views
  • Fixes alignment and hover styles for checkboxes in collaborator form
  • Moves Reports heading to top of page

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@TheDancingClown TheDancingClown merged commit ceceba6 into main Nov 18, 2024
10 of 11 checks passed
@TheDancingClown TheDancingClown deleted the qa1-a11y-fixes branch November 18, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants